Matt Simerson
a69cd6bf64
basicheaders: adding missing semicolon, fixed POD error
2012-06-04 03:34:47 -04:00
Matt Simerson
600b0db54d
plugins.pod: much simpler way to get debug logging
...
for individual plugins
2012-06-04 00:02:01 -07:00
Matt Simerson
c2d23306dc
badrcptto: remove spurious semicolon
2012-06-04 00:01:30 -07:00
Matt Simerson
086b31c546
connection_time: make compatible with tcpserver deployment
2012-06-04 00:00:37 -07:00
Ask Bjørn Hansen
0e2384cceb
Make all plugins use $self->connection rather than $self->qp->connection
...
Merge remote-tracking branch 'msimerson/connect'
Conflicts:
plugins/async/require_resolvable_fromhost
plugins/require_resolvable_fromhost
2012-06-03 23:53:43 -07:00
Ask Bjørn Hansen
bfa73240ae
Merge pull request #21 from msimerson/fromhost
...
resolvable_fromhost refactor, adding tests
2012-06-03 23:49:01 -07:00
Matt Simerson
0a16621f02
connection consistency
...
- $self->qp->connection->notes
+ $self->connection->notes
and all tests pass.
2012-06-02 00:46:33 -04:00
Matt Simerson
e8e47ad93b
move 'use ParaDNS' into register and eval it
...
so eventually, plugin tests can run against it, if ParaDNS can be loaded
2012-05-23 23:39:43 -04:00
Matt Simerson
2f49cafcd6
resolvable_fromhost: refactored, added: POD, tests, reject, reject_type
2012-05-23 23:39:43 -04:00
Ask Bjørn Hansen
9e239fd83d
Merge pull request #16 from msimerson/geoip
...
Geoip plugin improvements
2012-05-23 15:39:10 -07:00
Ask Bjørn Hansen
1fd65b8cd9
Merge pull request #17 from msimerson/basic
...
basicheaders, add reject option, loglevel
2012-05-23 15:38:12 -07:00
Matt Simerson
162f2c13e7
basicheaders: updated Changes with brief summary
2012-05-23 18:07:15 -04:00
Matt Simerson
23f06fde7a
basicheaders: removed deprecated argument warning
2012-05-23 17:56:06 -04:00
Matt Simerson
09935b0bf6
basicheaders: added whitelist support
...
because alerts.etrade.com doesn't set a Date header in alerts
2012-05-23 17:12:26 -04:00
Matt Simerson
80b94eb47a
removed newline
2012-05-22 18:14:10 -04:00
Matt Simerson
e07488d4f6
hrmm, why didn't Test::Qpsmtpd::Plugin::log work?
2012-05-22 17:41:40 -04:00
Matt Simerson
bb0a0cb19b
added geoip test file to MANIFEST
2012-05-22 17:41:01 -04:00
Matt Simerson
2dcd34467e
geoip: eval loading of Geo::IP, tests, enabled in config
...
eval Geo::IP and log an error if missing
added 2 tests
enabled in config/plugins
2012-05-22 17:40:02 -04:00
Matt Simerson
521aa4919f
basicheaders, add reject option, loglevel
...
added reject option
document the existence of the loglevel option
factored date validity tests into their own sub
added tests
improved POD
2012-05-21 21:30:02 -04:00
Ask Bjørn Hansen
d407f349b3
Merge pull request #14 from msimerson/dnsbl
...
dnsbl, POD tweaks, DENY type tests
2012-05-21 15:13:05 -07:00
Matt Simerson
9d0c2f8469
dnsbl, POD tweaks, DENY type tests
...
consolidated POD at top of file
added example options to reject_type POD head
added an example loglevel entry
consolidated DENY[SOFT|DISCONNECT] logic into get_reject_type
added tests for get_reject_type
2012-05-21 17:07:37 -04:00
Matt Simerson
ed8ce150be
domainkeys: fix failing tests
...
the previous DK commit moved the 'use Mail::DomainKeys::*' stuff into an eval. The right idea, but tests still fail because I forgot to remove the bare 'use' lines.
2012-05-21 12:17:32 -07:00
Matt Simerson
d5f15a7d33
enable domainkeys plugin
2012-05-21 08:30:48 -07:00
Matt Simerson
41550c2681
domainkeys: only register hooks if Mail::DomainKeys is loadable
2012-05-21 05:59:44 -04:00
Matt Simerson
efbaf2ec6f
added loglevel option for plugins
...
Plugins can now use a 'loglevel' argument in config/plugins entry
Includes user instructions prepended to docs/logging.pod
Already works for all plugins that use named arguments
2012-05-21 05:34:37 -04:00
Matt Simerson
15bf425fe4
greylisting: added upgrade note
2012-05-21 05:25:47 -04:00
Matt Simerson
51486d0b04
SPF plugin: refactored, tests, new config option
...
added POD description of spfquery note
changed spf_deny -> reject (and offered 4 more options, see POD for reject)
backwards compatible with old config settings
replicates qmail-smtpd SPF patch behavior
improved logging (again)
uses a stringy eval 'use Mail::SPF' in the register sub. If missing, warn and log the error, and don't register any hooks. This is much nicer error than the current, "*** Remote host closed connection unexpectedly." broken mail server that results from enabling the SPF plugin without Mail::SPF installed.
background: I noticed I was deferring valid emails with the SPF plugin at 'spf_deny 1', and without changing the code, there wasn't a way to change how ~all records were handled. This provides that flexibility.
2012-05-21 04:19:45 -04:00
Matt Simerson
edacbf914c
anglebrackets: emit log entry when change made
2012-05-20 23:41:15 -07:00
Matt Simerson
691955c60f
dnsbl: fixed path to docs/logging.pod
2012-05-20 23:41:09 -07:00
Matt Simerson
e8919beb0d
increment test counter declaration
2012-05-20 23:40:39 -07:00
Matt Simerson
96144a6a16
improve portability of basicheader plugin tests
...
replaced `date` with POSIX qw(strftime);
2012-05-20 23:40:35 -07:00
Matt Simerson
1c7d26ecca
dnsbl: added log messages, prefixes, additional args
...
instead of a positional arguments, used named arguments (backwards compatible)
added a couple log message prefixes
removed some trailing whitespace
updated POD
2012-05-20 23:40:23 -07:00
Matt Simerson
5e7568fe71
earlytalker: prefix messages with result keywords
2012-05-20 23:40:15 -07:00
Matt Simerson
4c6054c9fc
vpopmaild: logging improvements
...
added a couple logging calls
prefixed others with pass/skip/fail keywords
2012-05-20 23:40:11 -07:00
Matt Simerson
beca1e5e41
Q::Transaction, fix spelling error
...
s/Depreceated/Deprecated/
2012-05-20 23:40:08 -07:00
Matt Simerson
68c868c793
enable basicheaders plugin
2012-05-20 23:40:01 -07:00
Matt Simerson
49dc8bc117
basicheaders: added log messages, tests, named args
...
added log messages at each exit point
added tests
added reject_type option (defer -vs- deny)
added named argument parsing
2012-05-20 23:39:54 -07:00
Matt Simerson
f37fba7c2b
badrcptto: merged plugins, refactored, tests
...
merged badrcptto_pattern into badrcptto
refactored into smaller methods
added unit tests for each method
2012-05-20 23:39:38 -07:00
Matt Simerson
e206763428
test hostname before failing the test.
...
Test machine might have qmail installed with another hostname configured.
2012-05-20 23:39:24 -07:00
Matt Simerson
be28372dca
permit tests for async and ident plugins to work
2012-05-20 23:39:20 -07:00
Matt Simerson
19927a117e
spamassassin: added spam status to log messages
...
added additional values to tests, to suppress test warnings
2012-05-20 23:39:03 -07:00
Matt Simerson
c3d1f6b16e
p0f: tests, tests, tests, backward compat
...
minor changes to facilitate testing
improved error reporting of several failures
added p0f v2 compatibility to p0f v3 results: in addition to all the newer values, also report the old ones too.
2012-05-20 23:38:48 -07:00
Matt Simerson
25a099e20b
dspam: added check for autolearn
...
don't try to use autolearn if it's not set
added tests that exercise and exorcise the bug
2012-05-20 23:38:42 -07:00
Matt Simerson
ab258cfc2e
run: added forkserver section, instructions
...
added additional instructions
added forkserver startup
segregated local variables
reduced duplicated code
2012-05-20 23:38:29 -07:00
Matt Simerson
9b8c5a1be4
rcpt_ok: refactored and added tests
2012-05-20 23:37:37 -07:00
Matt Simerson
c4b8a7a395
hosts_allow: added logging, POD, deploy notes
...
added LOGINFO logging for denials, and LOGDEBUG for other results
added SEE ALSO pod
improved readability
2012-05-20 23:37:33 -07:00
Matt Simerson
ae3fe2e4d5
cleanups for Auth::validate_password commit
...
one for testing to work again
and one to remove MD5 dependency in Plugin.pm
2012-05-20 23:37:16 -07:00
Matt Simerson
35e1ce9883
consolidate auth logic into Qpsmtpd::Auth
...
These 3 auth plugins all have a data store they fetch the reference
password or hash from. They then match the attemped password or hash
against the reference. This consolidates the latter portion (validating
the password/hash) into Auth.pm.
* less duplicated code in the plugins.
* Pass validation consistently handled for these 3 plugins.
* less work to create new auth plugins
Also caches the CRAM-MD5 ticket. It could also cache user/pass info if
this was desirable.
2012-05-20 23:37:06 -07:00
Matt Simerson
b95b74bf48
ignore files created during testing
2012-05-20 23:36:45 -07:00
Matt Simerson
915b9830dc
greylisting: reset transaction for immunity tests
2012-05-20 23:35:59 -07:00