Commit Graph

2320 Commits

Author SHA1 Message Date
Jared Johnson
42c551944e Add some validation for passed db args 2015-02-23 14:13:39 -06:00
Jared Johnson
51ca3fcda4 Skip greylisting when we can't talk to greylist DB 2015-02-23 11:25:36 -06:00
Jared Johnson
4c9bcc0ee4 Configure but don't connect to DB in init_db()
This allows us to start up QP even if e.g. Redis is down
2015-02-23 11:25:18 -06:00
Matt Simerson
f7558f346d Merge pull request #232 from jaredj/mock-not-fake
Change fake_{config,hook} to mock_{config,hook}
2015-02-12 14:28:56 -08:00
Jared Johnson
5f6485e84f Change fake_{config,hook} to mock_{config,hook}
'mock' is more accurate and recognizable
2015-02-12 16:19:44 -06:00
Matt Simerson
e371159e38 Merge pull request #231 from jaredj/fake-greeting
Use a fake greeting for testing run_continuation()
2015-02-12 14:06:01 -08:00
Jared Johnson
95d40297cf Use a fake greeting for testing run_continuation()
This makes the test more universally useful in exercising run_continuation()
itself even with forks that e.g. use custom greetings
2015-02-12 15:53:50 -06:00
Jared Johnson
745ad55af2 Merge pull request #230 from smtpd/coveralls
add coveralls support
2015-02-11 16:49:48 -06:00
Matt Simerson
8d88fdb33d add coveralls support
* and coverage badge to README
2015-02-11 14:47:11 -08:00
Matt Simerson
08206bda40 updated Changes for 0.95 release 2015-02-11 14:00:25 -08:00
Matt Simerson
1ef0aa1008 Merge pull request #229 from jaredj/more-test
A little more testing for run_continuation()
2015-02-11 13:17:01 -08:00
Jared Johnson
d2079c455a A little more testing for run_continuation() 2015-02-11 15:07:10 -06:00
Jared Johnson
37c04cf728 Merge pull request #228 from msimerson/ar
limit split = to 2 fields
2015-02-11 14:56:53 -06:00
Matt Simerson
affd8c3f93 limit split = to 2 fields
(for cases where the field had more than one = sign)
2015-02-11 12:51:58 -08:00
Matt Simerson
f3872b1e66 Merge pull request #220 from biergaizi/master
[RFC] tls: adding support of Perfect Forward Secrecy
2015-02-09 14:38:58 -08:00
Matt Simerson
6687df2b6e Merge pull request #224 from salvis/can-on-unblessed-ref
Fix FATAL PLUGIN ERROR [whitelist]:  Can't call method "can"...
2015-02-05 17:37:33 -08:00
Hans Salvisberg
17c35c385d Fix FATAL PLUGIN ERROR [whitelist]: Can't call method "can" on unblessed reference at lib/Qpsmtpd/Config.pm line 38, <STDIN> line 1. 2015-02-06 02:16:33 +01:00
Matt Simerson
dfaeb1d795 Merge pull request #222 from jaredj/invalid-return
Don't interpret invalid return codes as OK
2015-02-03 15:16:55 -08:00
Jared Johnson
92d5ff6dc7 Fix test descriptions 2015-02-03 17:11:05 -06:00
Jared Johnson
dcdda3a5e7 Don't interpret invalid return codes as OK 2015-02-03 17:01:52 -06:00
Matt Simerson
b24f766cc5 Merge pull request #221 from jaredj/run-continuation-logging-tests
Tests for error logging in run_continuation()
2015-02-03 14:48:48 -08:00
Jared Johnson
f6b952ce8e Comment out broken test exposed by some test fixes 2015-02-03 16:44:06 -06:00
Jared Johnson
b3f8ce6b07 Tests for error logging in run_continuation() 2015-02-03 16:44:06 -06:00
Jared Johnson
7af1f770a5 Fix hook testing order
This exposes a bug with handling invalid return codes
2015-02-03 16:15:16 -06:00
Tom Li
a44c70232c tls_cert: fix a misused quotes
Signed-off-by: Tom Li <biergaizi2009@gmail.com>
2015-02-03 03:49:22 +08:00
Tom Li
2cc6d3f938 tls: checking if dhparam is empty, using "undef" instead of "" for clarity.
Signed-off-by: Tom Li <biergaizi2009@gmail.com>
2015-02-02 20:50:37 +08:00
Tom Li
edea4c239d tls_cert: unified cert name between tls and tls_cert.
Signed-off-by: Tom Li <biergaizi2009@gmail.com>
2015-02-02 18:36:51 +08:00
Tom Li
845760969b tls: fix a typo.
Signed-off-by: Tom Li <biergaizi2009@gmail.com>
2015-02-02 18:30:54 +08:00
Tom Li
2e2e6c70c6 tls: style fixes.
Signed-off-by: Tom Li <biergaizi2009@gmail.com>
2015-02-02 18:19:13 +08:00
Tom Li
acbbf66806 tls_cert: adding dhparam generating.
Signed-off-by: Tom Li <biergaizi2009@gmail.com>
2015-02-02 17:55:40 +08:00
Tom Li
d5954ce249 tls: adding support of dhparam.
Signed-off-by: Tom Li <biergaizi2009@gmail.com>
2015-02-02 17:55:22 +08:00
Tom Li
e6ee356925 tls: respect the order of specified ciphers.
Signed-off-by: Tom Li <biergaizi2009@gmail.com>
2015-02-02 17:37:15 +08:00
Matt Simerson
262857b1cb Merge pull request #219 from jaredj/run-continuation-tests
Moar testing for Qpsmtpd::run_continuation()
2015-01-29 23:53:35 -08:00
Jared Johnson
e2556a4ee9 Moar testing for Qpsmtpd::run_continuation() 2015-01-30 01:50:54 -06:00
Jared Johnson
a053ac7a32 Merge pull request #217 from msimerson/log-file
make sure $transaction->notes is blessed before
2015-01-29 15:32:41 -06:00
Matt Simerson
d9ac50f383 make sure $transaction->notes is blessed before
calling it as such. It doesn't resolve #199 but it does help there.

I'm not sure initializing Qpsmtpd::transaction as {} is a brilliant idea, but I haven't a better solution for that yet.
2015-01-29 11:25:14 -08:00
Jared Johnson
0d79c1ef8e Merge pull request #215 from msimerson/qmd
delete qmail-deliverable BEGIN block
2015-01-29 05:39:15 -06:00
Jared Johnson
a17b44de25 Merge pull request #214 from msimerson/summarize
log/summarize: ignore init msg from logging/*
2015-01-29 05:37:55 -06:00
Jared Johnson
194cde52af Merge pull request #213 from msimerson/geoip-debug
geoip: change a couple INFO -> DEBUG
2015-01-29 05:37:12 -06:00
Matt Simerson
fddf571988 Merge pull request #216 from msimerson/tcpserver2
Tcpserver2
2015-01-29 00:23:07 -08:00
Matt Simerson
cad4f2b1d6 TcpServer: don't 'use parent Qpsmtpd::Base'
it breaks stuff. Instead, grab a base object and use it
2015-01-29 00:15:43 -08:00
Matt Simerson
11ddf03164 disable qmail-deliverable BEGIN block
because FindBin has some undesirable global effects
2015-01-29 03:10:56 -05:00
Matt Simerson
98d148a0bf refactor start_connection 2015-01-29 00:04:13 -08:00
Matt Simerson
d7dd17085e log/summarize: ignore init msg from logging/* 2015-01-28 22:54:32 -08:00
Matt Simerson
bc4e7e61a5 geoip: change a couple INFO -> DEBUG 2015-01-28 22:10:06 -08:00
Matt Simerson
d81b2d4331 Merge pull request #147 from msimerson/tcpserver
update tcpenv and lrpip calls to use -> syntax
2015-01-28 20:08:53 -08:00
Matt Simerson
be9f4aef0c update tcpenv and lrpip calls to use -> syntax
don't load plugins twice.

Not exactly sure where that feature crept in some time ago. It was suppressed by checking to see if a queue plugin was already registered, and then bailing out on subsequent register_hook runs. I noticed it in testing, b/c I didn't have a queue plugin loaded. This removes the duplicate calls to register_hook.

* adds caching of the AUTH methods. You can't add new plugins or register new
  hooks w/o restarting QP, so cache the list and avoid having to generate it on every connection.

* other PBP changes (early exits, less indention, fewer unnecessary parens, etc.)
2015-01-28 19:58:58 -08:00
Matt Simerson
575c0b09e3 Merge pull request #209 from jaredj/notight
No tight square brackets or curly braces
2015-01-28 19:57:27 -08:00
Matt Simerson
04914bf4c9 Merge pull request #212 from salvis/dkim-doc-tweak
plugins/dkim doc tweak
2015-01-28 19:45:46 -08:00
Hans Salvisberg
c1e3652beb Tweak plugins/dkim doc to clarify the d= issue and add a third email reflector. 2015-01-29 02:05:28 +01:00