Commit Graph

2384 Commits

Author SHA1 Message Date
flimzy
5c9e7631ed Merge pull request #122 from msimerson/return_cleanups
Return cleanups
2014-09-18 05:52:14 -05:00
Matt Simerson
c3aa4c10d2 stunnel: cleanups 2014-09-17 23:00:31 -07:00
Matt Simerson
b289d38f53 more cleanups 2014-09-17 22:22:44 -07:00
Matt Simerson
c55fa030f8 Address: remove useless undef
and added tests to validate that they really are useless
2014-09-17 22:22:44 -07:00
Matt Simerson
72f1a7a962 Merge pull request #119 from flimzy/return_cleanups
Remove a ton of 'return ()', and a few other minor readability tweaks.
2014-09-17 22:19:53 -07:00
Matt Simerson
28e95be488 Merge pull request #120 from smtpd/test_warning
Silence a noisy test by passing an expected data type.
2014-09-17 19:35:26 -07:00
Jonathan Hall
555c87c52f Silence a noisy test by passing an expected data type. 2014-09-17 21:08:34 -05:00
Jonathan Hall
897a1fd8aa Remove a ton of 'return ()', and a few other minor readability tweaks. 2014-09-17 20:28:51 -05:00
Jared Johnson
26b1d0bb62 Merge pull request #112 from msimerson/qpsmtpd.t
Qpsmtpd.t
2014-09-17 18:04:55 -05:00
Matt Simerson
ba1a6a1885 remove YIELD cruft introduced by rebase 2014-09-17 13:09:47 -07:00
Matt Simerson
519bb12503 simplify config->from_file by not requiring full
file path. Instead, figure it out the same way as the 4 of the 5 caller do (by calling config_dir). Allow the 2nd arg to be the file name.
2014-09-17 13:03:46 -07:00
Matt Simerson
1e5d249224 added tests for run_hooks & run_hooks_no_respond 2014-09-17 13:03:46 -07:00
Matt Simerson
9a38850f13 added test for run_continuation 2014-09-17 13:03:46 -07:00
Matt Simerson
0499317912 Qpsmtpd: style changes in hook_responder 2014-09-17 13:02:44 -07:00
Matt Simerson
9cd8b165a0 qpsmtpd.t: added tests for hook_responder 2014-09-17 13:01:29 -07:00
Matt Simerson
820af9a26c Merge pull request #115 from msimerson/async
updated MANIFEST
2014-09-17 13:00:08 -07:00
Matt Simerson
96f4a99713 updated MANIFEST 2014-09-17 12:59:22 -07:00
Jared Johnson
f4ab59b613 Merge pull request #114 from msimerson/async
async removed
2014-09-17 14:02:51 -05:00
Matt Simerson
1e82ae1bc7 async removed
1. the known users of async don't upgrade
2. async becomes a win when concurrent connections exceed a few hundred simultaneous
3. anyone that needs async should be looking at Haraka instead
4. the perl async dependencies aren't maintained
2014-09-17 11:38:40 -07:00
Matt Simerson
ed3e550d7f Merge pull request #110 from msimerson/tests
remove test counters from plugin tests
2014-09-17 10:19:13 -07:00
flimzy
9fdb6b17d6 Merge pull request #107 from msimerson/version
add --tags to 'git describe'
2014-09-17 06:36:39 -05:00
flimzy
3ef0188f72 Merge pull request #111 from msimerson/pod
POD fixups
2014-09-17 06:28:36 -05:00
Matt Simerson
a5420149bd remove test counters from plugin tests
replace with done_testing(), which provides the same "make sure to kvetch if tests fail to run" without requiring humans to do the bookkeeping.
2014-09-17 00:11:32 -07:00
Matt Simerson
1ebe5ea6ec put git version detection code into a sub 2014-09-17 00:08:33 -07:00
Matt Simerson
4a48c4584d add --tags to 'git describe'
'git describe' calculates the version since the last **annotated** diff. Adding --tags shows the most recent tags (v0.94, for example) regardless if they're annotated or not.
2014-09-16 23:58:49 -07:00
Matt Simerson
5155e5c32f POD fixups 2014-09-16 23:27:19 -07:00
Matt Simerson
ef80767652 Merge pull request #109 from msimerson/master
updated MANIFEST
2014-09-16 21:54:44 -07:00
Matt Simerson
a1dc532dec updated MANIFEST
adding t/config/users.cdb (goes with closed PR #102)
2014-09-16 21:52:21 -07:00
Jared Johnson
d029c89113 Merge pull request #108 from msimerson/hooks
Q::hooks(), accept a hook name argument
2014-09-16 23:38:21 -05:00
Matt Simerson
d5481df3dd Q::hooks(), accept a hook name argument
and return a useful result
2014-09-16 21:22:36 -07:00
Jared Johnson
e50fee88c0 Merge pull request #106 from msimerson/disconnect
SMTP: don't create new Transaction at disconnect
2014-09-16 20:17:13 -05:00
Matt Simerson
7230de2ddc SMTP: don't create new Transaction at disconnect
the current result of passing a DENY* response is a new transaction. That seems wrong.
2014-09-16 17:56:58 -07:00
Matt Simerson
4f3ff19d1a Merge pull request #105 from jaredj/demote-warning
Demote warning to LOGDEBUG
2014-09-16 13:14:09 -07:00
Jared Johnson
58dc68b190 Demote warning to LOGDEBUG
it's not really very interesting when a map file doesn't exist for an optional config parameter
2014-09-16 15:12:42 -05:00
Matt Simerson
13f445596a Merge pull request #104 from flimzy/clam-opts
Fix clamdscan configuration handling
2014-09-16 12:10:18 -07:00
Jonathan Hall
f2bcd3736a New tests to cover new handling of register-time configuration. 2014-09-16 14:04:37 -05:00
Jonathan Hall
3d97773827 Reverse sense of is_not_multipart to is_multipart. 2014-09-16 13:57:15 -05:00
Jonathan Hall
ba3122bd82 Style cleanup
* no more 'return ()'
 * Explicit 'return 0'
2014-09-16 13:51:19 -05:00
Jonathan Hall
44cafde7d4 More complete clamdcscan tests
* construct our own Qpsmtpd::Transaction object for testing, so we're sure
   to have a pristine state
 * Move some logic into a should_scan() sub, to help separate scan_all from
   is_not_multipart (since the multipart state of a message has nothing to
   do with any configuration parameters)
2014-09-16 13:48:19 -05:00
Jonathan Hall
8344bf8439 Working toward functional virus/clamdscan tests. 2014-09-16 12:56:32 -05:00
flimzy
d36b9240f9 Merge pull request #102 from msimerson/Base.pm
Base.pm
2014-09-16 12:07:55 -05:00
Jonathan Hall
9faa1e1903 Fix clamdscan configuration handling
- Honor configured 'false' values
 - Treat 'scan_all' consistently with other options--permitting 0, 1, 'yes', or 'no' as values
2014-09-16 12:03:49 -05:00
Matt Simerson
a473c2732d updated Config::defaults() to behave as before
and added additional tests for it
2014-09-16 09:52:05 -07:00
Matt Simerson
b0c3d715cc moved config() from Qpsmtpd -> Q::Config.pm 2014-09-16 09:26:55 -07:00
Matt Simerson
d83268e448 Merge pull request #3 from flimzy/Base.pm
Kill some tab characters; PBP-suggested formatting for :? operator
2014-09-16 07:56:43 -07:00
Jonathan Hall
48bd0f3e0c Kill some tab characters; and adopt PBP-suggested formatting for :? operator. 2014-09-16 07:11:54 -05:00
Matt Simerson
b153c0ab99 more tests for Qpsmtpd::Config
* fix for cache clearing that didn't work
* imported a sample .cdb file for testing
2014-09-16 00:54:47 -07:00
Matt Simerson
75cb416b62 added diagnostics for failed spool_dir test
likely due to config caching
2014-09-16 00:03:28 -07:00
Matt Simerson
ebdb25a4bd extracted config*() from Qpsmtpd.pm -> Config.pm
* includes full test converage for Qpsmtpd::Config
    * folded t/config.t into t/qpsmtpd-config.t
* includes additional tests for Qpsmtpd
    * folded t/tempstuff into t/qpsmtpd.t
* PBP adjustments here and there
* other tweaks to handle test warnings
2014-09-15 23:41:31 -07:00
Matt Simerson
79d2b99211 Qpsmtpd: remove PLUGIN_DIR label, replace implicit
if statements with chained 'and' with if block (2x)
2014-09-15 19:00:07 -07:00