From e792c11bfa4aeb49498f01f3d005d4d93d95d237 Mon Sep 17 00:00:00 2001 From: Daniel Berteaud Date: Tue, 19 Apr 2016 18:18:03 +0200 Subject: [PATCH] Prevent a "Use of implicit split" warning In the helo plugin. Full warn is: Use of implicit split to @_ is deprecated at /usr/share/qpsmtpd/plugins/helo line 524 --- plugins/helo | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/helo b/plugins/helo index 134372c..e25d2cf 100644 --- a/plugins/helo +++ b/plugins/helo @@ -521,7 +521,8 @@ sub check_name_match { my ($dns_name, $helo_name) = @_; return if !$dns_name; - return if split(/\./, $dns_name) < 2; # not a FQDN + my @dots = split(/\./, $dns_name); + return if scalar @dots < 2; # not a FQDN if ($dns_name eq $helo_name) { $self->log(LOGDEBUG, "reverse name match");