diff --git a/Changes b/Changes index 142b01f..b9434ca 100644 --- a/Changes +++ b/Changes @@ -2,6 +2,9 @@ Support "module" plugins ("My::Plugin" in the config/plugins file) + Make the badmailfrom plugin support (optional) rejection messages after the + rejection pattern (Robin Hugh Johnson) + The ill-named $transaction->body_size() is depreceated now, use $transaction->data_size() instead. Check your logs for LOGWARN messages about "body_size" and fix your plugins. (Hanno Hecker) diff --git a/plugins/check_badmailfrom b/plugins/check_badmailfrom index 5030412..45267b5 100644 --- a/plugins/check_badmailfrom +++ b/plugins/check_badmailfrom @@ -1,7 +1,7 @@ # -*- perl -*- =head1 NAME -check_badmailfrom - checks the standard badmailfrom config +check_badmailfrom - checks the badmailfrom config, with per-line reasons =head1 DESCRIPTION @@ -13,6 +13,9 @@ recipient address for a message if the envelope sender address is listed in badmailfrom. A line in badmailfrom may be of the form @host, meaning every address at host." +You may optionally include a message after the sender address (leave a space), +which is used when rejecting the sender. + =head1 NOTES According to the SMTP protocol, we can't reject until after the RCPT @@ -33,11 +36,14 @@ sub hook_mail { my $from = lc($sender->user) . '@' . $host; for my $bad (@badmailfrom) { + my $reason = $bad; + $reason =~ s/^\s*(\S+)[\t\s]+//; + $reason = "sorry, your envelope sender is in my badmailfrom list" unless $reason; $bad =~ s/^\s*(\S+).*/$1/; next unless $bad; $bad = lc $bad; $self->log(LOGWARN, "Bad badmailfrom config: No \@ sign in $bad") and next unless $bad =~ m/\@/; - $transaction->notes('badmailfrom', "sorry, your envelope sender is in my badmailfrom list") + $transaction->notes('badmailfrom', $reason) if ($bad eq $from) || (substr($bad,0,1) eq '@' && $bad eq "\@$host"); } return (DECLINED);