byterazor/qpsmtpd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

improve portability of basicheader plugin tests

Browse Source 
replaced `date` with POSIX qw(strftime);
This commit is contained in:
Matt Simerson 2012-05-15 01:19:04 -04:00 committed by Robert
parent 1c7d26ecca
commit 96144a6a16
1 changed files with 22 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
t/plugin_tests/check_basicheaders
View File

@ -2,10 +2,12 @@
use strict; use strict;
use Data::Dumper; use Data::Dumper;
use POSIX qw(strftime);
use Qpsmtpd::Address; use Qpsmtpd::Address;
use Qpsmtpd::Constants; use Qpsmtpd::Constants;
sub register_tests { sub register_tests {
my $self = shift; my $self = shift;
@ -15,13 +17,16 @@ sub register_tests {
sub test_hook_data_post { sub test_hook_data_post {
my $self = shift; my $self = shift;
my $reject = $self->{_args}{reject_type};
my $deny = $reject =~ /^temp|soft$/i ? DENYSOFT : DENY;
my $transaction = $self->qp->transaction; my $transaction = $self->qp->transaction;
my $test_email = 'matt@example.com'; my $test_email = 'matt@example.com';
my $address = Qpsmtpd::Address->new( "<$test_email>" ); my $address = Qpsmtpd::Address->new( "<$test_email>" );
my $header = Mail::Header->new(Modify => 0, MailFrom => "COERCE"); my $header = Mail::Header->new(Modify => 0, MailFrom => "COERCE");
my $now = `date`; my $now = strftime "%a %b %e %H:%M:%S %Y", localtime time;
my $future = `date -v +6d`; my $future = strftime "%a %b %e %H:%M:%S %Y", localtime time + 518400; #6d
my $past = `date -v -6d`; my $past = strftime "%a %b %e %H:%M:%S %Y", localtime time - 518400; #6d
$self->{_args}{days} = 5; $self->{_args}{days} = 5;
$transaction->sender($address); $transaction->sender($address);
@ -35,29 +40,27 @@ sub test_hook_data_post {
$transaction->header->delete('Date'); $transaction->header->delete('Date');
($code, $mess) = $self->hook_data_post( $transaction ); ($code, $mess) = $self->hook_data_post( $transaction );
cmp_ok( DENY, '==', $code, "missing date ( $mess )" ); cmp_ok( $deny, '==', $code, "missing date ( $mess )" );
$transaction->header->delete('From');
$transaction->header->add('Date', $now ); $transaction->header->add('Date', $now );
$transaction->header->delete('From');
($code, $mess) = $self->hook_data_post( $transaction ); ($code, $mess) = $self->hook_data_post( $transaction );
cmp_ok( DENY, '==', $code, "missing from ( $mess )" ); cmp_ok( $deny, '==', $code, "missing from ( $mess )" );
$transaction->header->add('From', "<$test_email>");
if ( $future ) { $transaction->header->replace('Date', $future );
$transaction->header->replace('Date', $future ); ($code, $mess) = $self->hook_data_post( $transaction );
($code, $mess) = $self->hook_data_post( $transaction ); cmp_ok( $deny, '==', $code, "too new ( $mess )" );
cmp_ok( DENY, '==', $code, "too new ( $mess )" );
$transaction->header->replace('Date', $past ); $transaction->header->replace('Date', $past );
($code, $mess) = $self->hook_data_post( $transaction ); ($code, $mess) = $self->hook_data_post( $transaction );
cmp_ok( DENY, '==', $code, "too old ( $mess )" ); cmp_ok( $deny, '==', $code, "too old ( $mess )" );
}
else {
ok( 1, "skip: unable to use 'date' output");
ok( 1, "skip: unable to use 'date' output");
}
$self->{_args}{reject_type} = 'temp'; $self->{_args}{reject_type} = 'temp';
($code, $mess) = $self->hook_data_post( $transaction ); ($code, $mess) = $self->hook_data_post( $transaction );
cmp_ok( DENYSOFT, '==', $code, "defer, not deny ( $mess )" ); cmp_ok( DENYSOFT, '==', $code, "defer, not deny ( $mess )" );
$self->{_args}{reject_type} = 'perm';
($code, $mess) = $self->hook_data_post( $transaction );
cmp_ok( DENY, '==', $code, "deny ( $mess )" );
}; };