From 8c1c5c851d045da9b23b15396f85b8549990d399 Mon Sep 17 00:00:00 2001 From: Jared Johnson Date: Wed, 21 Jan 2015 17:31:47 -0600 Subject: [PATCH] Remove unnecessary calls to cleanup_and_return() prune_db() and migrate_db() already call unlock(), calling cleanup_and_return() only added a second (redundant) call to unlock() --- plugins/greylisting | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/greylisting b/plugins/greylisting index 16ba316..86d81b1 100644 --- a/plugins/greylisting +++ b/plugins/greylisting @@ -437,7 +437,7 @@ sub convert_db { } $self->db->unlock; $self->log(LOGINFO, "converted $converted of $count DB entries"); - return $self->cleanup_and_return(DECLINED); + return DECLINED; } sub prune_db { @@ -456,7 +456,7 @@ sub prune_db { } $self->db->unlock; $self->log(LOGINFO, "pruned $pruned of $count DB entries"); - return $self->cleanup_and_return(DECLINED); + return DECLINED; } sub exclude {