byterazor/qpsmtpd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix error checking for socket connections

Browse Source 
- IO::Socket::UNIX->new should never die, therefore...
- $@ is always undef when the eval exits, so...
- use $! instead
This commit is contained in:
Jonathan Hall 2014-12-30 06:23:33 -06:00
parent f8d66348f6
commit 86a1b312dc
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/ident/p0f
View File

@ -323,12 +323,9 @@ sub query_p0f_v3 {
my $query = $self->get_v3_query() or return;
# Open the connection to p0f
my $sock;
eval {
$sock = IO::Socket::UNIX->new(Peer => $p0f_socket, Type => SOCK_STREAM);
};
my $sock = IO::Socket::UNIX->new(Peer => $p0f_socket, Type => SOCK_STREAM);
if (!$sock) {
$self->log(LOGERROR, "skip, could not open socket: $@");
$self->log(LOGERROR, "skip, could not open socket: $!");
return;
}