Better fake_config() in t/plugin_tests/content_log

This commit is contained in:
Jared Johnson 2014-12-11 15:31:23 -06:00
parent 45da377897
commit 4f4e19ba0a

View File

@ -16,12 +16,11 @@ sub test_content_log_file {
is( $self->content_log_file, is( $self->content_log_file,
strftime('mail/%Y%m%d', localtime(time)), strftime('mail/%Y%m%d', localtime(time)),
'content_log_file() returns the right default value' ); 'content_log_file() returns the right default value' );
$self->save_hook; $self->fake_config( content_log_file => '/path/to/%Y%m%d%H%M' );
$self->fake_config('/path/to/%Y%m%d%H%M');
is( $self->content_log_file, is( $self->content_log_file,
strftime('/path/to/%Y%m%d%H%M', localtime(time)), strftime('/path/to/%Y%m%d%H%M', localtime(time)),
'content_log_file config changes content_log_file() output' ); 'content_log_file config changes content_log_file() output' );
$self->restore_hook; $self->unfake_config;
} }
sub test_content_log_enabled { sub test_content_log_enabled {
@ -65,39 +64,40 @@ sub test_content_log_enabled {
expected => 0, expected => 0,
}, },
); );
$self->save_hook;
for ( @test_data ) { for ( @test_data ) {
my $descr = "content_log_enabled=" my $descr = "content_log_enabled="
. ( defined $_->{config } ? "'$_->{config }'" : 'undef' ) . ( defined $_->{config } ? "'$_->{config }'" : 'undef' )
. ( $_->{expected} ? ' enables' : ' disables' ) . ( $_->{expected} ? ' enables' : ' disables' )
. ' content logging'; . ' content logging';
$self->fake_config( $_->{config } ); $self->fake_config( content_log_enabled => $_->{config } );
is( $self->content_log_enabled, $_->{expected}, $descr ); is( $self->content_log_enabled, $_->{expected}, $descr );
} }
$self->restore_hook; $self->unfake_config;
}
our $oldhook;
sub save_hook {
my ( $self ) = @_;
$oldhook = $self->qp->hooks->{config};
}
sub restore_hook {
my ( $self ) = @_;
$self->qp->hooks->{config} = $oldhook;
} }
sub fake_config { sub fake_config {
my ( $self, $value ) = @_; my $self = shift;
my $fake_config = {@_};
$self->qp->hooks->{config} = [ $self->qp->hooks->{config} = [
{ {
name => 'test hook', name => '___FakeHook___',
code => sub { return OK, $value }, code => sub {
my ( $self, $txn, $conf ) = @_;
return DECLINED if ! exists $fake_config->{$conf};
return OK, $fake_config->{$conf};
},
}, },
]; ];
} }
sub unfake_config {
my ( $self ) = @_;
$self->qp->hooks->{config} = [
grep { $_->{name} ne '___FakeHook___' }
@{ $self->qp->hooks->{config} || [] }
];
}
sub test_exclude { sub test_exclude {
my ( $self ) = @_; my ( $self ) = @_;
ok( ! $self->exclude, 'exclude() default method returns false' ); ok( ! $self->exclude, 'exclude() default method returns false' );