byterazor/qpsmtpd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FIX: verify dsn

Browse Source
This commit is contained in:
Dominik Meyer 2023-12-27 11:29:48 +01:00
parent 1197d6524e
commit 05ff0ad608
Signed by: byterazor
GPG Key ID: EABDA0FD5981BC97
1 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
plugins/rcpt_mysql
View File

@ -39,6 +39,16 @@ sub createDSN
$self->{dsn} = $dsn; $self->{dsn} = $dsn;
$self->log(LOGDEBUG, "created DSN " . $self->{dsn}); $self->log(LOGDEBUG, "created DSN " . $self->{dsn});
# try to parse the dsn to ensure it is valid
my @data = DBI->parse_dsn($self->{dsn});
if (@data == 0)
{
$self->log(LOGERROR, "DSN " . $self->{dsn} . " not valid");
$self->{dsn}="";
}
} }
sub createQuery sub createQuery
@ -180,20 +190,25 @@ sub askDatabase
my $self = shift; my $self = shift;
my $recipient = shift; my $recipient = shift;
$self->log(LOGDEBUG, "use DSN " . $self->{dsn}); if (length($self->{dsn}) == 0)
{
$self->log(LOGERROR, "DSN not valid not checking recipient in database");
return DECLINED;
}
my $dbh = DBI::connect($self->{dsn}, $self->{user}, $self->{pass}); my $dbh = DBI::connect($self->{dsn}, $self->{user}, $self->{pass});
if ($dbh->err()) if ($dbh->err())
{ {
warn("error connecting to DB: " . $dbh->errstr()); $self->log(LOGERROR, "error connecting to DB: " . $dbh->errstr());
return DENYSOFT; return DECLINED;
} }
my $sth = $dbh->prepare($self->{sqlquery}); my $sth = $dbh->prepare($self->{sqlquery});
if ($sth->err()) if ($sth->err())
{ {
warn("error preparing query: " . $sth->errstr()); $self->log(LOGERROR, "error preparing query: " . $sth->errstr());
return DENYSOFT; return DECLINED;
} }
$sth->execute($self->prepareParams($recipient)); $sth->execute($self->prepareParams($recipient));