From 75e6d2007bea069594d5f6d845376452c8dea1a6 Mon Sep 17 00:00:00 2001
From: Dominik Meyer <dmeyer@federationhq.de>
Date: Sun, 7 Jul 2019 21:59:10 +0200
Subject: [PATCH] FIX: fixed const correctness

---
 include/Tree/tree.hpp | 30 ++++++++++++------------------
 src/Tree/tree.cpp     |  8 ++++----
 2 files changed, 16 insertions(+), 22 deletions(-)

diff --git a/include/Tree/tree.hpp b/include/Tree/tree.hpp
index ca16f78..76ffc2a 100644
--- a/include/Tree/tree.hpp
+++ b/include/Tree/tree.hpp
@@ -23,16 +23,11 @@ GNU General Public License for more details.
 You should have received a copy of the GNU General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-
-
-
-
-
-
 #include <memory>
 #include <string>
 #include <list>
 #include <algorithm>
+#include <iostream>
 
 /**
 * @brief main namespace for the libtree++ library
@@ -57,11 +52,11 @@ namespace Tree
     * @brief get the root of the tree
     *
     */
-    std::shared_ptr<Tree::BaseNode> getRoot()
+    std::shared_ptr<Tree::BaseNode> getRoot() const
     {
       if (parent==nullptr)
       {
-        return shared_from_this();
+        return std::const_pointer_cast<Tree::BaseNode>(shared_from_this());
       }
 
       return parent->getRoot();
@@ -131,14 +126,14 @@ namespace Tree
     *
     * @return iterator to the beginning of the list of children
     */
-    std::list<std::shared_ptr<Tree::BaseNode>>::iterator getChildrenBegin() {return children.begin();}
+    std::list<std::shared_ptr<Tree::BaseNode>>::const_iterator getChildrenBegin() const {return children.begin();}
 
     /**
     * @brief returns an iterator to the end of the list of children
     *
     * @return iterator to the end of the list of children
     */
-    std::list<std::shared_ptr<Tree::BaseNode>>::iterator getChildrenEnd() {return children.end();}
+    std::list<std::shared_ptr<Tree::BaseNode>>::const_iterator getChildrenEnd() const {return children.end();}
 
     /**
     * @brief returns the nr of direct children
@@ -227,7 +222,7 @@ namespace Tree
     * @return nullptr - a node of that type could not be found
     * @return the found node as a shared_ptr
     */
-    std::shared_ptr<Tree::BaseNode> findNext(const std::string &t);
+    std::shared_ptr<const Tree::BaseNode> findNext(const std::string &t) const;
 
     /**
     * @brief finds all nodes of a given type
@@ -236,13 +231,12 @@ namespace Tree
     * @param c    - a container for holding all found nodes, has to be holding objects of type std::shared_ptr<Tree::BaseNode>
     */
     template <typename Container>
-    void findAll(const std::string &t, Container &c)
+    void findAll(const std::string &t, Container &c) const
     {
-      std::list<std::shared_ptr<Tree::BaseNode>>::iterator it;
-
+      std::list<std::shared_ptr<Tree::BaseNode>>::const_iterator it;
       if (type() == t)
       {
-        c.push_back(shared_from_this());
+        c.push_back(std::const_pointer_cast<Tree::BaseNode>(shared_from_this()));
       }
 
       for(it = children.begin(); it != children.end(); ++it)
@@ -259,13 +253,13 @@ namespace Tree
     * @param c    - a container for holding all found nodes, has to be holding objects of type std::shared_ptr<Tree::BaseNode>
     */
     template <class Container>
-    void findAllBase(const std::string &b, Container &c)
+    void findAllBase(const std::string &b, Container &c) const
     {
-      std::list<std::shared_ptr<Tree::BaseNode>>::iterator it;
+      std::list<std::shared_ptr<Tree::BaseNode>>::const_iterator it;
 
       if (base() == b)
       {
-        c.push_back(shared_from_this());
+        c.push_back(std::const_pointer_cast<Tree::BaseNode>(shared_from_this()));
       }
 
       for(it = children.begin(); it != children.end(); ++it)
diff --git a/src/Tree/tree.cpp b/src/Tree/tree.cpp
index d946a61..0ab8a05 100644
--- a/src/Tree/tree.cpp
+++ b/src/Tree/tree.cpp
@@ -20,10 +20,10 @@ along with this program.  If not, see <https://www.gnu.org/licenses/>.
 #include <Tree/tree.hpp>
 
 
-std::shared_ptr<Tree::BaseNode> Tree::BaseNode::findNext(const std::string &t)
+std::shared_ptr<const Tree::BaseNode> Tree::BaseNode::findNext(const std::string &t) const
 {
-  std::list<std::shared_ptr<Tree::BaseNode>>::iterator childIT;
-  std::shared_ptr<Tree::BaseNode> temp;
+  std::list<std::shared_ptr<Tree::BaseNode>>::const_iterator childIT;
+  std::shared_ptr<const Tree::BaseNode> temp;
 
   if (type() == t )
   {
@@ -72,7 +72,7 @@ void Tree::BaseNode::printTree(const uint32_t depth)
 
   std::cout << toString() << std::endl;
 
-  std::list<std::shared_ptr<Tree::BaseNode>>::iterator childIT;
+  std::list<std::shared_ptr<Tree::BaseNode>>::const_iterator childIT;
 
   for(childIT=getChildrenBegin(); childIT != getChildrenEnd(); ++childIT)
   {